Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix security certificate error message format. #171

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

fix security certificate error message format. #171

wants to merge 1 commit into from
+1 −0

Conversation

fujitatomoya
Copy link
Collaborator

closes #170

missing string value for the format.

introduced by #167.

@fujitatomoya fujitatomoya requested a review from ahcorde February 26, 2025 18:59
@fujitatomoya fujitatomoya self-assigned this Feb 26, 2025
fujitatomoya
fujitatomoya commented Feb 26, 2025
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde can you take a look and merge?

i am not sure why this is not detected by CI with #167.

@fujitatomoya fujitatomoya mentioned this pull request Feb 26, 2025
Open
@fujitatomoya
Copy link
Collaborator Author

Pulls: #171
Gist: https://gist.githubusercontent.com/fujitatomoya/a1bd0be9a7cd11147b341aa5aaa199f9/raw/eade078da70a6fb9f26c4f57cbc36e977447a31b/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15247

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/fix-error-certificate-msg branch from b15666c to 14bf9ad Compare February 26, 2025 19:35
@fujitatomoya
Copy link
Collaborator Author

CI:
Building on the built-in node in workspace /var/lib/jenkins/workspace/ci_launcher

  • Linux Build Status
  • Linux-aarch64 Build Status (supposed to fail)
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@christophebedard christophebedard christophebedard approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Rolling CI warning: format ‘%s’ expects a matching ‘char*’
3 participants
@fujitatomoya @ahcorde @christophebedard