Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild warnings in serdata.cpp #90

Closed
brawner opened this issue Jan 23, 2020 · 1 comment · Fixed by #98
Closed

MSBuild warnings in serdata.cpp #90

brawner opened this issue Jan 23, 2020 · 1 comment · Fixed by #98

Comments

@brawner
Copy link
Contributor

brawner commented Jan 23, 2020

Bug report

Required Info:
Building on Windows 10, 1903 in a docker container with the latest VCTools (16.24) installed from VS BuildTools.
https://citest.ros2.org/job/nightly_win_extra_rmw_rel/10/warnings43Result/

I get a couple of MSBuild warnings,
serdata.cpp:115

'initializing': conversion from 'size_t' to 'uint32_t', possible loss of data

Looks to be introduced in #77

serdata.cpp:506

unary minus operator applied to unsigned type, result still unsigned

Introduced in #75

@rotu

@brawner
Copy link
Contributor Author

brawner commented Jan 23, 2020

Looks like these warnings have been around for awhile though. https://ci.ros2.org/job/ci_windows/8800/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant