From 0425c082c57365ef0d0412e6e3bc47319e420914 Mon Sep 17 00:00:00 2001 From: Jacob Perron Date: Mon, 9 Nov 2020 13:53:45 -0800 Subject: [PATCH] Remove unexpected template name being passed to TypeSupport class MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The TypeSupport class is not a template class. To be honest, I'm not sure how the code was compiling before this change as I would have expected there to be an error "expected template-name before ‘<’ token". I noticed this suddenly appearing during the ABI check for Foxy, for example: http://build.ros2.org/job/Fpr__rmw_fastrtps__ubuntu_focal_amd64/75/API_5fABI_20report/ Signed-off-by: Jacob Perron --- .../include/rmw_fastrtps_shared_cpp/MessageTypeSupport.hpp | 2 +- .../include/rmw_fastrtps_shared_cpp/ServiceTypeSupport.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/MessageTypeSupport.hpp b/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/MessageTypeSupport.hpp index 8ff2cc1b0..a17650d40 100644 --- a/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/MessageTypeSupport.hpp +++ b/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/MessageTypeSupport.hpp @@ -27,7 +27,7 @@ namespace rmw_fastrtps_shared_cpp { template -class MessageTypeSupport : public TypeSupport +class MessageTypeSupport : public TypeSupport { public: explicit MessageTypeSupport(const MembersType * members); diff --git a/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/ServiceTypeSupport.hpp b/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/ServiceTypeSupport.hpp index 6fac2bd32..0b4abb5e3 100644 --- a/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/ServiceTypeSupport.hpp +++ b/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/ServiceTypeSupport.hpp @@ -27,7 +27,7 @@ namespace rmw_fastrtps_shared_cpp { template -class ServiceTypeSupport : public TypeSupport +class ServiceTypeSupport : public TypeSupport { protected: ServiceTypeSupport();