Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Fedora development setup. #289

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

richmattes
Copy link
Contributor

Updates to support the build-from-source instructions. Tested by following the from source installation instructions with these updates in a fedora:30 docker container. See the commit message for more details on the individual changes.

Even with the changes in this PR, ros2 dashing still fails to build on a clean Fedora install in some cases due to ros2/rosidl_python#66 and ros2/rviz#402.

Updates to support the build-from-source instructions.  Tested by
following the directions on the wiki in a fedora:30 docker container.

python3-lark-parser-0.7.1 is available in f29 and f30 - remove the pip
installation.

colcon needs to be installed via pip, and requires a version of pytest
greater than the version available in the Fedora repos (3.9).  --upgrade
is required to install over the system-wide 3.9 version.

wget and rosdep are required by the build from source instructions, and
not installed by default.

gcc-c++, patch, and make are required to build C++ packages, and may not
be installed on a fresh system. redhat-rpm-config provides hardening
flags that gcc-c++ needs.

liblsan is needed to build rosbag2 (the sanitizer isn't installed by
default when gcc-c++ is installed).  It should probably be disabled by
default, and/or added as a system rosdep.

Signed-off-by: Rich Mattes <[email protected]>
@cottsay cottsay self-assigned this Jul 1, 2019
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colcon is part of Fedora 29 and newer - no need to use pip: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8c1b78e3f3

The lark parser pip install was a stopgap until the update went stable, which has happened, so that is OK to remove from pip: https://bodhi.fedoraproject.org/updates/FEDORA-2019-069bbc9184

Update the package list to use dnf to install python3-colcon-common
extensions, which is available in Fedora 29 and newer:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-8c1b78e3f3

Remove pip command - all relevant dependencies can be installed with the
system package manager.

Also, a couple of cosmetic updates:
- Put each package on a new line to match the Linux Development Setup
page formatting
- Alphabatize package list
- Re-word first paragraph to reflect that the setup is now a single
step.

Signed-off-by: Rich Mattes <[email protected]>
@richmattes
Copy link
Contributor Author

Thanks for the info, I've updated the docs to remove the pip install step altogether.

It looks like colcon took quite some effort (26 separate packages?!) - kudos to you for getting that all through!

@cottsay
Copy link
Member

cottsay commented Jul 2, 2019

I was granted a review exemption since the packages were so similar. Looks like the EPEL 7 update just cleared testing, so it should be available there, too.

@cottsay cottsay merged commit b2f520a into ros2:master Jul 2, 2019
@cottsay cottsay removed the in review label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants