Fix issue with ros2bag record python frontend #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add _subparser member variable ( which is being called at line number 94). Otherwise it causes segmentation fault on calling ros2 bag record. Signed-off-by: Sagnik <[email protected]>
Add type info to parser Signed-off-by: Sagnik <[email protected]>
Karsten1987
approved these changes
Apr 30, 2019
|
thanks a lot for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently "ros2 bag record" command causes crashes when used with arguments. The PR fixes it.
@Karsten1987 review and get back to me.