Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1043 Writer choices set to list #1044

Merged
merged 2 commits into from
Jul 26, 2022
Merged

#1043 Writer choices set to list #1044

merged 2 commits into from
Jul 26, 2022

Conversation

EsipovPA
Copy link
Contributor

Solution proposal for issue #1043

@EsipovPA EsipovPA requested a review from a team as a code owner July 17, 2022 22:58
@EsipovPA EsipovPA requested review from gbiggs and hidmic and removed request for a team July 17, 2022 22:58
@EsipovPA EsipovPA mentioned this pull request Jul 17, 2022
Closed
@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented Jul 26, 2022 •
edited
Loading

Running CI:
Gist: https://gist.githubusercontent.com/MichaelOrlov/02ac01bb15b80faf24fc6c7d286e55ea/raw/2b4f8b427717dfd86579ee5862a286892cd4b6f8/ros2.repos
BUILD args: --packages-above-and-dependencies ros2bag rosbag2_tests
TEST args: --packages-above ros2bag rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10575

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

MichaelOrlov
MichaelOrlov approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with "green" CI.

@MichaelOrlov MichaelOrlov merged commit 9291bcb into ros2:rolling Jul 26, 2022
@EsipovPA EsipovPA deleted the writer_choices_set_to_list branch July 27, 2022 07:52
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-8-18-2022/27050/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vayerx vayerx vayerx left review comments

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs was automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic was automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EsipovPA @MichaelOrlov @ros-discourse @vayerx