-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for excluding topics via regular expressions #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any immediately obvious issues.
@jhdcs thanks for the prompt review. One thing that differs from |
I feel like keeping it consistent would be best, at least for the moment. If in future we decide that we need to have multiple regular expression support, we can open a new issue at that time and change everything over. |
Signed-off-by: Esteve Fernandez <[email protected]>
@jhdcs I've updated this PR so that |
Gist: https://gist.githubusercontent.com/MichaelOrlov/4ddd09a6f289164fd88305e18d2c6c78/raw/06ed49f0a9fbb6fc94981ef7e363abac755edc6f/ros2.repos |
@jhdcs @MichaelOrlov the CI issues don't seem to be related to the changes in this PR, but I could be wrong. Did they happen in previous PRs? |
@esteve Yes this is known issue and unrelated to the changes from this PR. |
This PR adds
--exclude
(and-x
) as an option toros2 bag play
to exclude topics from being replayed.