Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable play end-to-end tests when deterministic start is available #109

Open
Karsten1987 opened this issue May 3, 2019 · 1 comment
Open
Assignees
Labels
bug Something isn't working tests Failing or missing tests

Comments

@Karsten1987
Copy link
Collaborator

Karsten1987 commented May 3, 2019

The current play end-to-end tests cannot be executed reliably as the publishers are sending their messages before any subscriber can be matched in a deterministic fashion. In order to push the repos further towards the ros2.repos integration, we disabled this test. See conversation here:
#104 (comment)

This can be re-enabled when a more deterministic start of replaying a rosbag is available. One way to work towards this is to introduce a --paused option to start a rosbag, prepare all publishers but don't start publishing directly. This allows discovery to match with the respective subscribers to guarantee receiving all sent messages.

@Karsten1987 Karsten1987 self-assigned this May 3, 2019
@emersonknapp emersonknapp added the bug Something isn't working label Jan 29, 2020
@Karsten1987
Copy link
Collaborator Author

when re-enabling these tests, please add a "legacy" test for testing rosbags with versions <= 4.
Original comment here: #345 (review)

@chapulina chapulina added the tests Failing or missing tests label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Failing or missing tests
Projects
None yet
Development

No branches or pull requests

3 participants