rosbag2_cpp: test more than one storage plugin #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
requested review from
gbiggs and
emersonknapp
and removed request for
a team
james-rms
force-pushed
the
jrms/test-mcap-rosbag2-cpp
branch
7 times, most recently
from
18af3f8 to
813d604
Compare
emersonknapp
requested changes
Dec 6, 2022
rosbag2_test_common/include/rosbag2_test_common/bag_filename_for_storage_id.hpp
Outdated
Show resolved
Hide resolved
rosbag2_test_common/include/rosbag2_test_common/tested_storage_ids.hpp
Outdated
Show resolved
Hide resolved
james-rms
force-pushed
the
jrms/test-mcap-rosbag2-cpp
branch
2 times, most recently
from
4c981f4 to
3a87fd8
Compare
james-rms
force-pushed
the
jrms/test-mcap-rosbag2-cpp
branch
from
3a87fd8 to
f1a44ff
Compare
Signed-off-by: James Smith <[email protected]>
Signed-off-by: James Smith <[email protected]>
james-rms
force-pushed
the
jrms/test-mcap-rosbag2-cpp
branch
from
f1a44ff to
412827f
Compare
Signed-off-by: James Smith <[email protected]>
Signed-off-by: James Smith <[email protected]>
|
Gist: https://gist.githubusercontent.com/james-rms/d5d9f03159bffe918986d4b0dde89606/raw/bcc49a4ebbd695559fe6e15dca8538bb2c7aca89/ros2.repos
|
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2024
* rosbag2_storage_mcap: fix rosbag2_cpp tests Signed-off-by: James Smith <[email protected]> * rosbag2_cpp: test several storage plugins Signed-off-by: James Smith <[email protected]> * rosbag2_transport: specify test dependency on plugins Signed-off-by: James Smith <[email protected]> * ros2bag: add default plugins for testing Signed-off-by: James Smith <[email protected]> Signed-off-by: James Smith <[email protected]> (cherry picked from commit 9d7d7c3) # Conflicts: # mcap_vendor/CMakeLists.txt # rosbag2_cpp/test/rosbag2_cpp/test_info.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_reader.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_writer.cpp # rosbag2_storage_mcap/CMakeLists.txt # rosbag2_storage_mcap/src/mcap_storage.cpp
1 task
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 23, 2024
* rosbag2_storage_mcap: fix rosbag2_cpp tests Signed-off-by: James Smith <[email protected]> * rosbag2_cpp: test several storage plugins Signed-off-by: James Smith <[email protected]> * rosbag2_transport: specify test dependency on plugins Signed-off-by: James Smith <[email protected]> * ros2bag: add default plugins for testing Signed-off-by: James Smith <[email protected]> Signed-off-by: James Smith <[email protected]> (cherry picked from commit 9d7d7c3) # Conflicts: # mcap_vendor/CMakeLists.txt # rosbag2_cpp/test/rosbag2_cpp/test_info.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_reader.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_writer.cpp # rosbag2_storage_mcap/CMakeLists.txt # rosbag2_storage_mcap/src/mcap_storage.cpp
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 23, 2024
…) (#1721) * rosbag2_cpp: test more than one storage plugin (#1196) * rosbag2_storage_mcap: fix rosbag2_cpp tests Signed-off-by: James Smith <[email protected]> * rosbag2_cpp: test several storage plugins Signed-off-by: James Smith <[email protected]> * rosbag2_transport: specify test dependency on plugins Signed-off-by: James Smith <[email protected]> * ros2bag: add default plugins for testing Signed-off-by: James Smith <[email protected]> Signed-off-by: James Smith <[email protected]> (cherry picked from commit 9d7d7c3) # Conflicts: # mcap_vendor/CMakeLists.txt # rosbag2_cpp/test/rosbag2_cpp/test_info.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_reader.cpp # rosbag2_cpp/test/rosbag2_cpp/test_sequential_writer.cpp # rosbag2_storage_mcap/CMakeLists.txt # rosbag2_storage_mcap/src/mcap_storage.cpp * Rebase and address merge conflicts Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: james-rms <[email protected]> Co-authored-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parametrizes rosbag2_cpp unit tests to run using some set of "tested" storage plugins - for now this is just
sqlite3andmcap, but once #1160 is done I expect this would be defined as "the set of default storage plugins".It also updates
rosbag2_storage_mcapto pass those tests. Before this PR the mcap storage plugin reader does not correctly restart iteration from after the last read message.TODO