-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic_name option to info verb #1217
Conversation
Signed-off-by: Keisuke Shima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeisukeShima Thanks for the PR.
I think "--quiet"
option for showing just topics names is too generic.
It will make more sense to name it more explicitly something like "--topic_name"
.
Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
@MichaelOrlov Thanks for review.
I agree with you. Changed PR title and code. |
Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
d064d5f
to
f63713d
Compare
Gist: https://gist.githubusercontent.com/MichaelOrlov/bc4ad30bda92639fffd415673159a430/raw/5f2042a177ea3d131e0d11c701c6c9ef51dbac7a/ros2.repos |
@KeisukeShima Newly added test fails on Windows. Could you please take a look on failure? |
Signed-off-by: Keisuke Shima <[email protected]>
@MichaelOrlov |
@KeisukeShima It turns out that now test fails due to different file size |
Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-01-19/29423/1 |
In some use cases we may want to get a list of topic names. For this reason I have added the quiet option to a info verb.
Signed-off-by: Keisuke Shima [email protected]