Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic_name option to info verb #1217

Merged
merged 10 commits into from
Dec 23, 2022

Conversation

KeisukeShima
Copy link
Contributor

In some use cases we may want to get a list of topic names. For this reason I have added the quiet option to a info verb.

Signed-off-by: Keisuke Shima [email protected]

Signed-off-by: Keisuke Shima <[email protected]>
@KeisukeShima KeisukeShima requested a review from a team as a code owner December 19, 2022 07:46
@KeisukeShima KeisukeShima requested review from MichaelOrlov and jhdcs and removed request for a team December 19, 2022 07:46
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KeisukeShima Thanks for the PR.
I think "--quiet" option for showing just topics names is too generic.
It will make more sense to name it more explicitly something like "--topic_name".

@KeisukeShima KeisukeShima changed the title Add quiet option to info verb Add topic_name option to info verb Dec 20, 2022
@KeisukeShima
Copy link
Contributor Author

@MichaelOrlov Thanks for review.

I think "--quiet" option for showing just topics names is too generic.
It will make more sense to name it more explicitly something like "--topic_name".

I agree with you. Changed PR title and code.

Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Keisuke Shima <[email protected]>
Signed-off-by: Keisuke Shima <[email protected]>
@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/bc4ad30bda92639fffd415673159a430/raw/5f2042a177ea3d131e0d11c701c6c9ef51dbac7a/ros2.repos
BUILD args: --packages-above-and-dependencies ros2bag rosbag2_tests
TEST args: --packages-above ros2bag rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11307

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

@KeisukeShima Newly added test fails on Windows. Could you please take a look on failure?

Signed-off-by: Keisuke Shima <[email protected]>
@KeisukeShima
Copy link
Contributor Author

@MichaelOrlov
The cause of the ci failure on Windows is due to a different line break code. This has been corrected by using the normalize_lineseps function for standard output.

@MichaelOrlov
Copy link
Contributor

Re-running Windows CI job

  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

@KeisukeShima It turns out that now test fails due to different file size
Bag size: 49.2 KiB instead of "Bag size: 49.1 KiB"
Feel free to disable or delete this test_info_with_no_options test.

@MichaelOrlov
Copy link
Contributor

Re-running Windows CI job after removing test

  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 38b1757 into ros2:rolling Dec 23, 2022
@KeisukeShima KeisukeShima deleted the baginfo-quiet-mode branch January 4, 2023 00:25
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-01-19/29423/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants