Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient Local topics should optionally appear in all bag splits. #1234

Closed
vinnnyr opened this issue Jan 21, 2023 · 2 comments
Closed

Transient Local topics should optionally appear in all bag splits. #1234

vinnnyr opened this issue Jan 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@vinnnyr
Copy link

vinnnyr commented Jan 21, 2023

Description

When creating bag splits, the transient local topics (such as /tf_static) that we expect on the system are only written to the first bag of the split series, rather than all of the splits.

While that makes sense, I would like the option to write all transient local topics in all the bags, since I ideally want to be able to use the split bag as a self contained data log, rather than depending on the first bag for information such as /tf_static.

Related Issues

I am not sure.

Completion Criteria

  • Ros2 bag cli option to optionally "add transient local data to all bags".

Implementation Notes / Suggestions

** If you have ideas about how this feature might be accomplished, put them here. Note that this is just a suggestion to the implementer, so feel free to speculate. **

I am not quite sure yet.

Testing Notes / Suggestions

** All features in this project need tests. Please give some input on cases that will need to be tested - and how the testing might be implemented. **

Integration Test:

  1. publish a transient local topic (idea: tf_static)
  2. record a bag with splits enabled, as well as this new feature
  3. delete the first bag
  4. make sure tf_static is contained in subsequent bags.
@vinnnyr vinnnyr added the enhancement New feature or request label Jan 21, 2023
@emersonknapp
Copy link
Collaborator

This is a duplicate of #1159

@vinnnyr
Copy link
Author

vinnnyr commented Jan 21, 2023

sorry about that! I didn't recognize it initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants