Add CLI option to expose bagfile splitting #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajakta-gokhale
force-pushed
the
splitting/cli-changes
branch
from
a4817d1 to
022f429
Compare
|
@prajakta-gokhale do you want to rebase this to the latest master to have it being able to run CI? |
prajakta-gokhale
force-pushed
the
splitting/cli-changes
branch
from
022f429 to
cc61435
Compare
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
Signed-off-by: Prajakta Gokhale <[email protected]>
prajakta-gokhale
force-pushed
the
splitting/cli-changes
branch
from
cc61435 to
ae9796b
Compare
|
CI:
@prajakta-gokhale just fyi, please feel free to tag me/comment on a ticket after a rebase or such. I don't get a notification if you push a commit. |
|
We may have to restart the Linux build. It passed when I ran locally. |
|
CI again: |
Karsten1987
approved these changes
Nov 18, 2019
piraka9011
pushed a commit
to aws-ros-dev/rosbag2
that referenced
this pull request
Nov 18, 2019
* Change writer to support bagfile split feature Signed-off-by: Prajakta Gokhale <[email protected]> * Change sqlite_storage to support bagfile splitting Signed-off-by: Prajakta Gokhale <[email protected]> * Change Writer to support changes to sqlite_storage bagfile splitting Signed-off-by: Prajakta Gokhale <[email protected]> * Add CLI option to split recording into multiple files Signed-off-by: Prajakta Gokhale <[email protected]> * Merge rosbag2/master Signed-off-by: Prajakta Gokhale <[email protected]> * Make help text short and succinct Signed-off-by: Prajakta Gokhale <[email protected]> * Fix flake8 errors Signed-off-by: Prajakta Gokhale <[email protected]> * Rebase on master Signed-off-by: Prajakta Gokhale <[email protected]>
piraka9011
pushed a commit
to aws-ros-dev/rosbag2
that referenced
this pull request
Nov 18, 2019
* Add CLI option to expose bagfile splitting (ros2#203) * Change writer to support bagfile split feature Signed-off-by: Prajakta Gokhale <[email protected]> * Change sqlite_storage to support bagfile splitting Signed-off-by: Prajakta Gokhale <[email protected]> * Change Writer to support changes to sqlite_storage bagfile splitting Signed-off-by: Prajakta Gokhale <[email protected]> * Add CLI option to split recording into multiple files Signed-off-by: Prajakta Gokhale <[email protected]> * Merge rosbag2/master Signed-off-by: Prajakta Gokhale <[email protected]> * Make help text short and succinct Signed-off-by: Prajakta Gokhale <[email protected]> * Fix flake8 errors Signed-off-by: Prajakta Gokhale <[email protected]> * Rebase on master Signed-off-by: Prajakta Gokhale <[email protected]> * generate changelog Signed-off-by: Karsten Knese <[email protected]> * 0.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the bagfile splitting functionality in
ros2 bag record.Related to https://github.com/ros-security/aws-roadmap/issues/6