Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros2 bag record -a records also hidden topics #331

Closed
Karsten1987 opened this issue Mar 26, 2020 · 0 comments · Fixed by #332
Closed

ros2 bag record -a records also hidden topics #331

Karsten1987 opened this issue Mar 26, 2020 · 0 comments · Fixed by #332
Labels
bug Something isn't working

Comments

@Karsten1987
Copy link
Collaborator

Description

When calling ros2 bag record -a, really all topics are recorded. This includes also hidden topics.
This became a problem while developing rosbag support for rmw_iceoryx_cpp in which there are reserved internal topics, which don't have an appropriate message definition and thus can't be recorded.
For more details see: ros2/rmw_iceoryx#13

Expected Behavior

Hidden topics are not recorded by default for the above mentioned reasons.

Actual Behavior

rosbag2 is crashing due to not finding appropriate message definition packages.

Additional context

An ideal solution would be to have an option --include-hidden-topics which explicitly records the internal topics as well.
@Karsten1987 Karsten1987 added the bug Something isn't working label Mar 26, 2020
@Karsten1987 Karsten1987 mentioned this issue Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include hidden topics ros2/rosbag2
1 participant
@Karsten1987