Validate QoS profile values are not negative. #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Ikawa <[email protected]>
|
Need to add unit test |
Signed-off-by: Jesse Ikawa <[email protected]>
|
After confirming this test case works, split into 4 test cases to individually test: depth, deadline, lifespan, liveliness_lease_duration |
emersonknapp
reviewed
Aug 3, 2020
Signed-off-by: Jesse Ikawa <[email protected]>
emersonknapp
reviewed
Aug 3, 2020
emersonknapp
reviewed
Aug 3, 2020
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
|
Will 'sec' and 'nsec' be the only time duration values for QoS profile in the future? If not I should revise to cover any time duration value. |
dabonnie
reviewed
Aug 4, 2020
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
Signed-off-by: Jesse Ikawa <[email protected]>
emersonknapp
approved these changes
Aug 5, 2020
Linux-aarch64 infra failure, automated re-run |
|
@jikawa-az @emersonknapp can this PR be backported? If so, it would be great if you could come up with a backport PR today so we can cut a new release for rosbag2. |
dabonnie
pushed a commit
that referenced
this pull request
Aug 5, 2020
* add negative check to init py Signed-off-by: Jesse Ikawa <[email protected]> * add unit test Signed-off-by: Jesse Ikawa <[email protected]> * modify unit test Signed-off-by: Jesse Ikawa <[email protected]> * revert test_play Signed-off-by: Jesse Ikawa <[email protected]> * typo string to int Signed-off-by: Jesse Ikawa <[email protected]> * add history value to unit tests Signed-off-by: Jesse Ikawa <[email protected]> * add validation to duration keys Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify comparison Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]>
dabonnie
pushed a commit
that referenced
this pull request
Aug 5, 2020
* add negative check to init py Signed-off-by: Jesse Ikawa <[email protected]> * add unit test Signed-off-by: Jesse Ikawa <[email protected]> * modify unit test Signed-off-by: Jesse Ikawa <[email protected]> * revert test_play Signed-off-by: Jesse Ikawa <[email protected]> * typo string to int Signed-off-by: Jesse Ikawa <[email protected]> * add history value to unit tests Signed-off-by: Jesse Ikawa <[email protected]> * add validation to duration keys Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify comparison Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]> Signed-off-by: Devin Bonnie <[email protected]>
Karsten1987
pushed a commit
that referenced
this pull request
Aug 5, 2020
* add negative check to init py Signed-off-by: Jesse Ikawa <[email protected]> * add unit test Signed-off-by: Jesse Ikawa <[email protected]> * modify unit test Signed-off-by: Jesse Ikawa <[email protected]> * revert test_play Signed-off-by: Jesse Ikawa <[email protected]> * typo string to int Signed-off-by: Jesse Ikawa <[email protected]> * add history value to unit tests Signed-off-by: Jesse Ikawa <[email protected]> * add validation to duration keys Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify duration validation Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify comparison Signed-off-by: Jesse Ikawa <[email protected]> * fix syntax Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]> * modify style Signed-off-by: Jesse Ikawa <[email protected]> Signed-off-by: Devin Bonnie <[email protected]> Co-authored-by: Jesse Ikawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
Signed-off-by: Jesse Ikawa [email protected]