Add record test for ros2bag #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A nominal smoke test to confirm that the tool is working. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
force-pushed
the
jacob/add_ros2bag_record_test
branch
from
371e8a5 to
5857220
Compare
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
|
Testing with
|
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
jacobperron
force-pushed
the
jacob/add_ros2bag_record_test
branch
from
6236696 to
48dbcad
Compare
|
Windows: |
Karsten1987
approved these changes
Oct 19, 2020
adamdbrw
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Add record test for ros2bag A nominal smoke test to confirm that the tool is working. Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix lint Signed-off-by: Jacob Perron <[email protected]> * Expect exit code 2 from rclcpp Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix test for Windows Signed-off-by: Jacob Perron <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Add record test for ros2bag A nominal smoke test to confirm that the tool is working. Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix lint Signed-off-by: Jacob Perron <[email protected]> * Expect exit code 2 from rclcpp Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix test for Windows Signed-off-by: Jacob Perron <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Add record test for ros2bag A nominal smoke test to confirm that the tool is working. Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix lint Signed-off-by: Jacob Perron <[email protected]> * Expect exit code 2 from rclcpp Signed-off-by: Jacob Perron <[email protected]> * Remove unused import Signed-off-by: Jacob Perron <[email protected]> * Fix test for Windows Signed-off-by: Jacob Perron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nominal smoke test to confirm that the tool is working.
This should hopefully catch bugs like #522, before they get released.
I think it's worth backporting this test.