Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all storage plugins in plugin xml file #554

Merged

Conversation

Barry-Xu-2018
Copy link
Contributor

Related issue #553

@Barry-Xu-2018 Barry-Xu-2018 requested a review from a team as a code owner October 31, 2020 03:06
@Barry-Xu-2018 Barry-Xu-2018 requested review from Karsten1987 and dabonnie and removed request for a team October 31, 2020 03:06
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! Thank you.

@Karsten1987 Karsten1987 merged commit 90a6759 into ros2:master Nov 2, 2020
emersonknapp pushed a commit that referenced this pull request Feb 2, 2021
emersonknapp pushed a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants