Recorder --regex and --exclude options #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdbrw
requested review from
thomas-moulard and
jaisontj
and removed request for
a team
mjeronimo
approved these changes
Jan 20, 2021
adamdbrw
changed the title
- you can use -x or --regex option now to specify how topics are recorded - this new option is exclusive with -a and specifying topics (for simplicity) - to be supplemented with tests.. Signed-off-by: Adam Dabrowski <[email protected]>
Signed-off-by: Adam Dabrowski <[email protected]>
Signed-off-by: Adam Dabrowski <[email protected]>
adamdbrw
force-pushed
the
record_with_topic_regex
branch
from
7922478 to
c318f75
Compare
Signed-off-by: Adam Dabrowski <[email protected]>
adamdbrw
force-pushed
the
record_with_topic_regex
branch
from
24b21c4 to
c3fc263
Compare
|
@mjeronimo can I ask for a review and if this is alright, to run jobs? |
emersonknapp
requested changes
Jan 25, 2021
rosbag2_tests/test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp
Outdated
Show resolved
Hide resolved
rosbag2_tests/test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp
Outdated
Show resolved
Hide resolved
adamdbrw
changed the title
Signed-off-by: Adam Dabrowski <[email protected]>
emersonknapp
approved these changes
Jan 25, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/20bbe7e473b4159fb5f88662b552963c/raw/656e51e4a43294405eae946a887b2d838489c554/ros2.repos
|
This was referenced Jan 26, 2021
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Regex and exclude options for recording topics - you can use -e or --regex option now to specify how topics are recorded - can use -x or --exclude to exclude topics from recording - regex is exclusive with -a and specifying topics (for simplicity) Signed-off-by: Adam Dabrowski <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Regex and exclude options for recording topics - you can use -e or --regex option now to specify how topics are recorded - can use -x or --exclude to exclude topics from recording - regex is exclusive with -a and specifying topics (for simplicity) Signed-off-by: Adam Dabrowski <[email protected]>
|
is this still usable? cant seem rosbag2 cant seem to recognize -x flag for regex |
|
@purentap Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #559 and #560. This is a minimal implementation that brings the regex filtering feature to rosbag2.
Implements ros2 bag record -e / --regex and -x / --exclude options to specify how topics are recorded.