Load compression and serialization choices via plugin query #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camm73
requested review from
mjeronimo and
prajakta-gokhale
and removed request for
a team
added 6 commits
July 29, 2021 15:12
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
Signed-off-by: Cameron Miller <[email protected]>
…gins Signed-off-by: Cameron Miller <[email protected]>
camm73
force-pushed
the
cameron/compression-serialization-query
branch
from
19258ef to
b0f6b76
Compare
emersonknapp
changed the title
emersonknapp
approved these changes
Jul 29, 2021
|
Note linter errors: I will run the ci.ros2.org job once the Github workflows are green |
Signed-off-by: Cameron Miller <[email protected]>
camm73
force-pushed
the
cameron/compression-serialization-query
branch
from
6c5bc11 to
437d1e6
Compare
|
camm73
added a commit
to camm73/rosbag2
that referenced
this pull request
Aug 6, 2021
* For the `ros2 bag record` CLI - don't hardcode available choices, instead query for what is installed Signed-off-by: Cameron Miller <[email protected]>
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
* For the `ros2 bag record` CLI - don't hardcode available choices, instead query for what is installed Signed-off-by: Cameron Miller <[email protected]> Signed-off-by: Wojciech Jaworski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #769
Query installed plugins to dynamically set compression and serialization format choices in the
ros2 bag record -hhelp menu.Also added "compression" and "decompression" choices to
ros2 bag listfor listing available compression and decompression plugins.