Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bag split doesn't work during recording when cache enabled #939

Closed
MichaelOrlov opened this issue Dec 14, 2021 · 1 comment · Fixed by #936
Closed

Bag split doesn't work during recording when cache enabled #939

MichaelOrlov opened this issue Dec 14, 2021 · 1 comment · Fixed by #936
Assignees
@MichaelOrlov
Labels
bug Something isn't working

Comments

@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented Dec 14, 2021 •
edited
Loading

Description

Bag split doesn't work during recording when cache enabled.

Expected Behavior

Rosbag2 record multiple files when split enabled alongside with double buffering cache mode.

Actual Behavior

Rosbag2 records only first file and when split happen dropping all other messages.

To Reproduce

  1. ros2 bag record -a -b 100000 --max-cache-size 1024

System (please complete the following information)

  • OS: Ubuntu 20.04
  • ROS 2 Distro: Rolling
  • Version: master 200c4c3

Additional context

Issue was discovered during post merge code review of the PR #850
@MichaelOrlov MichaelOrlov added the bug Something isn't working label Dec 14, 2021
@MichaelOrlov MichaelOrlov self-assigned this Dec 14, 2021
@MichaelOrlov MichaelOrlov mentioned this issue Dec 14, 2021
Merged
@MichaelOrlov
Copy link
Contributor Author

MichaelOrlov commented Dec 14, 2021 •
edited
Loading

RCA: In #850 was occasionally removed restart for the cache consumer thread after the bag split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelOrlov MichaelOrlov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix for broken bag split when using cache ros2/rosbag2
1 participant
@MichaelOrlov