Revert "Add the ability to record any key/value pair in the 'custom' … #984
Conversation
|
Reproducing the failure: |
|
@MichaelOrlov Thanks for taking a look! Sometimes the test regressions only happen on the buildfarm, I'm just checking to make sure it's not related to other changes happening on the stack. |
|
Reproducing the failure + Revert PR |
|
cc: @t0ny-peng |
|
FYI: @clalancette |
|
@t0ny-peng @MichaelOrlov Given that this PR is clearly the cause of the regressions we are seeing, and that today is the API and feature freeze, I'm thinking that we should go ahead with this PR and revert this. Thoughts? |
|
@clalancette Please revert it as discussed if it's causing trouble. Sorry I don't have Windows machine to debug this flaky test. |
|
All right, here is full CI on this revert PR to check:
|
|
@Blast545 Can you please sign-off on the revert commit to make the DCO bot happy? |
…field in metadata.yaml (#976)" This reverts commit e156eb9. Signed-off-by: Jorge Perez <[email protected]>
Blast545
force-pushed
the
blast545/revert_rosbag2_976
branch
from
7072d71 to
4be3dd4
Compare
|
@clalancette Yes! Just forced push the signoff and marked the PR ready for review. |
|
I'm going to go ahead and merge this one for now. We can reinstate it onto Rolling (in two weeks time) once the CI failures have been investigated. |
…custom' field in metadata.yaml (#976)" (#984)" This reverts commit e7d4975. Signed-off-by: Hunter L. Allen <[email protected]>
…custom' field in metadata.yaml (#976)" (#984)" This reverts commit e7d4975. Signed-off-by: Hunter L. Allen <[email protected]>
…adata.yaml (#1038) * Revert "Revert "Add the ability to record any key/value pair in the 'custom' field in metadata.yaml (#976)" (#984)" This reverts commit e7d4975. Signed-off-by: Hunter L. Allen <[email protected]> * Ensure writer_ is destructed before intercepted_metadata_ Signed-off-by: Hunter L. Allen <[email protected]>
…adata.yaml (#1038) * Revert "Revert "Add the ability to record any key/value pair in the 'custom' field in metadata.yaml (#976)" (#984)" This reverts commit e7d4975. Signed-off-by: Hunter L. Allen <[email protected]> * Ensure writer_ is destructed before intercepted_metadata_ Signed-off-by: Hunter L. Allen <[email protected]>
…field in metadata.yaml (#976)"
Just checking if the current errors in the buildfarm come from that PR.
https://ci.ros2.org/view/nightly/job/nightly_win_rel/2257/testReport/junit/rosbag2_compression/SequentialCompressionWriterTest/open_throws_on_bad_compression_format/
This reverts commit e156eb9.