Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating messages services in an action folder #9

Closed
sloretz opened this issue Oct 18, 2018 · 1 comment
Closed

Allow generating messages services in an action folder #9

sloretz opened this issue Oct 18, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@sloretz
Copy link
Contributor

sloretz commented Oct 18, 2018

Feature request

Feature description

rosidl_typesupport_fastrtps_c and rosidl_typesupport_fastrtps_cpp need to allow generating messages and services in an action folder and namespace

Implementation considerations

The service templates would need to change to allow service definitions to live in the .actions folder

#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Request'))__rosidl_typesupport_fastrtps_c.h"
#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Response'))__rosidl_typesupport_fastrtps_c.h"

#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name))__struct.hpp"
#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Request'))__rosidl_typesupport_fastrtps_cpp.hpp"
#include "@(spec.pkg_name)/srv/@(get_header_filename_from_msg_name(spec.srv_name + '_Response'))__rosidl_typesupport_fastrtps_cpp.hpp"

connects to ros2/rosidl#301

@sloretz sloretz added the enhancement New feature or request label Oct 18, 2018
@sloretz sloretz added this to the crystal milestone Oct 18, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Oct 18, 2018

Actually I'm not sure about this issue. If actions are implemented in rcl, why should an rmw specific typesupport need to be aware of them? It seems like the only thing to do here would be allow generating services in a folder other than srv so that rosidl_generate_c could invoke this generator with services and messages in an action namespace.

Edit: Changed this issue to say as much

This was referenced Oct 18, 2018
@sloretz sloretz changed the title Generate C typesupport for Actions Allow generating messages services in an action folder Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant