Support Fast CDR v2 #114
Merged
Support Fast CDR v2 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Mar 20, 2024
There was a problem hiding this comment.
I think this one needs to be rebased on top #113 (at least, it seems to me that includes some of the same changes).
Once that is done I'll do another review.
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
support-fast-cdr-2
branch
from
925df83 to
ca20c7a
Compare
Signed-off-by: Miguel Company <[email protected]>
clalancette
requested changes
Mar 21, 2024
| @@ -30,7 +30,7 @@ | |||
| <build_export_depend>rosidl_typesupport_interface</build_export_depend> | |||
|
|
|||
| <!-- Needed for headers in this package, or the headers it generates, and also needs to be linked in downstream packages --> | |||
| <depend>fastcdr</depend> | |||
| <depend version_gte="2">fastcdr</depend> | |||
There was a problem hiding this comment.
Same comment as in ros2/rmw_fastrtps#746 (comment)
There was a problem hiding this comment.
I did it, but didn't push: a725fbb
| @@ -32,7 +32,7 @@ | |||
| <build_export_depend>rosidl_typesupport_interface</build_export_depend> | |||
|
|
|||
| <!-- Needed for headers in this package, or the headers it generates, and also needs to be linked in downstream packages --> | |||
| <depend>fastcdr</depend> | |||
| <depend version_gte="2">fastcdr</depend> | |||
There was a problem hiding this comment.
Same comment as in ros2/rmw_fastrtps#746 (comment)
There was a problem hiding this comment.
I did it, but didn't push: a725fbb
clalancette
approved these changes
Mar 21, 2024
Signed-off-by: Miguel Company <[email protected]>
|
@clalancette The tests that were updated in #113 were not updated here. I've fixed that in 7fb44ae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the necessary changes to allow building with Fast CDR v2
Part of ros2/ros2#1530
It is built on top of #113