Skip to content
This repository has been archived by the owner on Dec 9, 2021. It is now read-only.

Allow generating messages services in an action folder #6

Closed
sloretz opened this issue Oct 18, 2018 · 0 comments
Closed

Allow generating messages services in an action folder #6

sloretz opened this issue Oct 18, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sloretz
Copy link
Contributor

sloretz commented Oct 18, 2018

Feature request

Feature description

rosidl_typesupport_opensplice_c and rosidl_typesupport_opensplice_cpp need to allow generating messages and services in an action folder and namespace

Implementation considerations

The service templates would need to change to allow service definitions to live in the .actions folder

#include "@(spec.pkg_name)/srv/@(req_header_file_name).h"
#include "@(spec.pkg_name)/srv/@(res_header_file_name).h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_@(spec.srv_name)_Request_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_@(spec.srv_name)_Response_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_Sample_@(spec.srv_name)_Request_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_Sample_@(spec.srv_name)_Response_.h"

#include "@(spec.pkg_name)/srv/@(req_header_file_name)__rosidl_typesupport_opensplice_cpp.hpp"
#include "@(spec.pkg_name)/srv/@(res_header_file_name)__rosidl_typesupport_opensplice_cpp.hpp"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_@(spec.srv_name)_Request_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_@(spec.srv_name)_Response_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_Sample_@(spec.srv_name)_Request_.h"
#include "@(spec.pkg_name)/srv/dds_opensplice/ccpp_Sample_@(spec.srv_name)_Response_.h"

connects to ros2/rosidl#301

@sloretz sloretz added the enhancement New feature or request label Oct 18, 2018
@sloretz sloretz added this to the crystal milestone Oct 18, 2018
@sloretz sloretz mentioned this issue Oct 18, 2018
24 tasks
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Oct 23, 2018
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants