-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for search placeholder text #59
Comments
What text would you use? Just to understand your use case. I think we don't allow any text configuration at the moment (except for user generated content, like groups in the nav). Adding this to the configuration doesn't feel right. I would rather add support for translations in the whole app (but that's a bit more work). |
This is for https://learn-eleventy.pages.dev/, I'd like to make it say "Search for lessons by title or content." which is how I have it on the deployed site. Updating at the minute and trying to avoid customizing .app as much this time. |
Thanks for explanation, makes sense. I will see if adding translations is viable option. |
I created a first prototype that adds translation to the search ui. With // @ts-check
import { defineTranslations } from "./.app/app-translations.js";
export const translations = defineTranslations({
lang: "de",
translations: {
"search.input.placeholder": "Suchen...",
"search.popover.placeholder": "Suche nach Titel, Inhalt und #tag",
// ...
},
}); |
Eleventy Notes v0.26.0 is released 🎉 It now supports translations for all UI elements. Read more about in the docs: https://eleventy-notes.sandroroth.com/n/features/language/ |
I'd like to able to configure/override this "Search by title, content and #tags" text easily in the configuration file.
The text was updated successfully, but these errors were encountered: