Should tests check for error tokens?

[dblessing]

When reviewing a PR I noticed there was an error token in the sample for the Nix lexer. I originally thought the change caused it so I tested on master, but the problem still existed. I thought automated testing was ensuring there were no error tokens.

When I look at specs it looks like we assert no errors for the demo, but not the sample. Samples we only check to see if it throws an exception.

Are tests supposed to catch error tokens in samples? @gfx @jneen

[miparnisari]

This is exactly why I submitted #852 :)

[stale]

This contribution has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.

[pyrmont]

@dblessing I don't think it should be a problem if samples include an error. Not sure if @jneen or @gfx feel differently.

[stale]

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

[pyrmont]

Having had the benefit of working on this codebase for a year, I'm confident the answer to this should be no. There are samples that intentionally include errors to check the way error tokens work.