Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some git/config options can be useful to load (like credential.helper) #125

Closed
dguibert opened this issue Sep 19, 2023 · 3 comments
Closed

Comments

@dguibert
Copy link

https://github.com/rraval/git-nomad/blame/096e0b5a9fb3caabf6bfb14bf0c0e75963517748/src/git_binary.rs#L27
unsetting HOME and XDG_CONFIG_HOME avoids to load ~/.config/git/config.

Every time I run git nomad sync it asks for my login/password. But credential helpers (cache, password-store or store) are configured in my git/config.

Maybe unwanted options could be filtered out with -c bad_option=.

@rraval
Copy link
Owner

rraval commented Sep 19, 2023

Thanks for raising this issue.

The environment variable suppression dates to a much earlier design that had mandatory configuration and a git nomad init subcommand. All of this was overhauled in 0.4.0 and #5.

I think this code path can be dropped outright. Will fix and cut a new release.

@rraval rraval closed this as completed in c6d45b9 Sep 22, 2023
@rraval
Copy link
Owner

rraval commented Sep 22, 2023

@dguibert I've published v0.7.0 which should contain a fix for this issue. Give it a shot and re-open in case I've missed something.

Thanks again for reporting this.

@dguibert
Copy link
Author

thank you, working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants