Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowroot support not working properly #754

Closed
maximilianMairinger opened this issue Nov 8, 2021 · 1 comment
Closed

Shadowroot support not working properly #754

maximilianMairinger opened this issue Nov 8, 2021 · 1 comment

Comments

@maximilianMairinger
Copy link

A recent project of mine heavily utilizes nested custom elements with shadowroots. I tried implementing rrweb but failed. Here is a running example (implementing the getting started guide; view source recording start and recording play): http://035401c.xcenic.maximilian.mairinger.com/admin/. After clicking "Stop recording" view the recording object in the console. Everything outside the first shadowroot is properly recorded, but nothing inside (very similar to a lot of other solutions out there).

I noticed however your effort to support shadow roots and tried setting a decently low checkoutEveryNms time. Which worked, although at the cost of absurdly high cpu utilization (not surprising), proving that the pure serialization process works.

@Yuyz0112
Copy link
Member

looks like the new PR from @Mark-Fenng fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants