Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing Origin as an allowed request header is unnecessary #151

Closed
jub0bs opened this issue Jun 9, 2023 · 4 comments
Closed

Listing Origin as an allowed request header is unnecessary #151

jub0bs opened this issue Jun 9, 2023 · 4 comments

Comments

@jub0bs
Copy link
Contributor

jub0bs commented Jun 9, 2023

The middleware lists Origin as an allowed request header (see here and here). However, listing Origin is never necessary because that header is added to requests by the browser, never by the client. You can safely drop Origin from that list.

@vibovenkat123
Copy link

Working on fix #155

@rs
Copy link
Owner

rs commented Jul 22, 2023

Apparently some old version of Safari required that header to be present during preflight: 849a49a

@jub0bs
Copy link
Contributor Author

jub0bs commented Jul 23, 2023

If that used to be true (I haven't been able to find any evidence for this claim), those old versions of Safari are likely long gone and not used by many people.

@rs rs closed this as completed in 5288ed0 Sep 5, 2023
@jub0bs
Copy link
Contributor Author

jub0bs commented Sep 5, 2023

Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants