All requests on a TCP connection share a global, mutable scope

[trestletech]

Any modifications to the req object persist across separate HTTP requests. If you run the following and hit it from the same browser, you'll see the counter increment.

I suppose there are benefits to this, but it seems unexpected when compared to e.g. Express.

httpuv::runServer("0.0.0.0", 3000,list(
  call = function(req){
    if (is.null(req$counter)){
      req$counter <- 0
    }
    req$counter <- req$counter + 1
    print(req$counter)

    list(
      status= 200L,
      headers = list(
        'Content-type' = 'text/html'
      ), body = "hi there"
    )
  }, onHeaders = function(req){
    NULL
  }, onWSOpen = function(ws){
    NULL
  }
))

[wch]

This now works correctly on master.