Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature add variant sequential view #68

Merged
merged 9 commits into from
Jun 19, 2017
Merged

Feature add variant sequential view #68

merged 9 commits into from
Jun 19, 2017

Conversation

acki-m
Copy link
Contributor

@acki-m acki-m commented Jun 18, 2017

This pull request will add a new class called: variant_sequential_view
Advantage:

  • by default values are returned by std::reference_wrapper
  • support for range based for loops
  • no dynamic memory allocation when creating the view
  • less internal code

REMARK: variant_array_view is from now on deprecated and might be removed from further releases

fixes #46

acki-m added 8 commits May 30, 2017 23:14
@acki-m
initial commit for adding 'variant_sequential_view'
9c5c8f5 
just copied and paste the code from the 'variant_associative_view'
Next step: change implementation
@acki-m
adjusted implementation of various classes to support sequential cont…
55bf243 
…ainer view
@acki-m
added new methods in variant_sequential_view
38d95c6 
is_dynamic()
get_rank()
get_rank_type(std::size_t)
set_size(std::size_t)

added several unit tests

added support for following standard sequential containers:
* std::vector, std::list, std::array, std::deque
@acki-m
added support for raw arrays and std::initializer_list<T> in variant_…
94fbad0 
…sequential_view

marked variant_array_view as deprecated
@acki-m
added get_value and set_value function to variant_sequential_view
a5bac51 
also added unit tests for it
@acki-m
adjust existing code to not use variant_array_view anymore
3087c92
@acki-m
fixed compile error with gcc < 4.9.0
bced856 
'no matching function for call to `std::vector<bool>::erase(const const_itr_t&) return container.erase(itr);`
vec.erase(vec.cbegin()); fails for unkown reason with this old version
@acki-m
another gcc bug, the same but with vector::insert
77489e6
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 94.268% when pulling 77489e6 on acki-m:feature-add-variant-sequential-view into 03ca4e1 on rttrorg:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 94.268% when pulling 77489e6 on acki-m:feature-add-variant-sequential-view into 03ca4e1 on rttrorg:master.

@acki-m acki-m closed this Jun 19, 2017
@acki-m acki-m reopened this Jun 19, 2017
@acki-m acki-m closed this Jun 19, 2017
@acki-m acki-m reopened this Jun 19, 2017
@coveralls
Copy link

coveralls commented Jun 19, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 91.459% when pulling 84264a9 on acki-m:feature-add-variant-sequential-view into 03ca4e1 on rttrorg:master.

@acki-m acki-m merged commit 27152c1 into rttrorg:master Jun 19, 2017
@acki-m acki-m deleted the feature-add-variant-sequential-view branch March 5, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add variant_sequential_view class
2 participants
@acki-m @coveralls