Allow non_bare_access_modifier_declaration?
to handle modifiers with multiple arguments
#325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when testing
Style/AccessModifierDeclarations
. When an access modifier has multiple arguments,non_bare_access_modifier_declaration?
erroneously (IMO) returns false, which causes the cop to not recognize all cases it should.The cop does not properly recognize (as a positive or negative, depends on the
AllowModifiersOnSymbols
configuration) this despite the examples for the cop including it.I have a follow up PR to
Style/AccessModifierDeclarations
coming once this can be merged.