Introduce lhs and rhs aliases to assignment nodes for consistency.
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
bquorning
reviewed
Nov 4, 2024
The methods are already available for `masgn`, so this will allow all assignment node types to have the same two methods so that they can be dealt with in unison.
dvandersluis
force-pushed
the
asgn-lhs-rhs
branch
from
5fe11d7 to
7acd630
Compare
|
Looks good, thank you. Released as 1.34.0. Minor thing: If you think about it for upcoming PRs, please make a Changelog entry... |
|
Sorry @marcandre! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods are already available for
masgn, so this will allow all assignment node types to have the same two methods so that they can be dealt with in unison. Once released I've found some places in rubocop where more destructuring can be simplified.Follows rubocop/rubocop#13413 (comment)
I didn't add tests for these aliases but am happy to if desired!