Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix traversal #117

Closed
marcandre opened this issue Sep 18, 2020 · 0 comments
Closed

Fix traversal #117

marcandre opened this issue Sep 18, 2020 · 0 comments
Assignees
@marcandre

Comments

@marcandre
Copy link
Contributor

  1. Handle all node types (even unknown ones)
  2. Optimize
  • avoid locating the symbols all the time
  • on_send can be optimized; others "custom" ones should be removed.
@marcandre marcandre self-assigned this Sep 18, 2020
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Future-proof Traversal by detecting unknown Nod…
2186dc3 
…e types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
bb7e331 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument

Minor:
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
5f324a5 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument

Minor:
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
500992e 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument

Minor:
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
cf738c9 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument

Minor:
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
7940e6e 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument

Minor:
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
8ea5020 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument.

Minor:
- `procarg0` (modern mode) had none of its children visited
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Oct 11, 2020
@marcandre
[Fixes rubocop#117] Refactor Traversal with a simple "compiler". Ad…
5be5683 
…d stricter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument.

Minor:
- `procarg0` (modern mode) had none of its children visited
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
marcandre added a commit that referenced this issue Oct 12, 2020
@marcandre
[Fixes #117] Future-proof Traversal by detecting unknown Node types
9595a51
marcandre added a commit that referenced this issue Oct 12, 2020
@marcandre
[Fixes #117] Refactor Traversal with a simple "compiler". Add stric…
1a08da6 
…ter typing.

Bug fix: `next` and `break` were incorrectly specified as having a single argument.

Minor:
- `procarg0` (modern mode) had none of its children visited
- `kwarg` never has a second argument.
- added a few missing node types.
- test now checks the number of children
- test now checks we know of all node types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcandre marcandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcandre