-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow *%W for better readability (Lint/UnneededSplatExpansion) #7041
Comments
I can see the benefit of improved readability. I feel like this is a highly specific use case. I'm not sure that there is a great solution for this. A few ideas that I have are:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
The problem is still present in 0.74.0. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
I guess this is still a problem. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it. |
In certain scenarios, using
*%W
may improve readability. So there should be exceptions to:Lint/UnneededSplatExpansion
Most of those scenarios are when building shell commands.
E.g.:
Be aware, that
system
is not the only method covered by this.Open3....
is also affected and I'm actually using a custom method with adds additional checks when running external command. So excludingLint/UnneededSplatExpansion
for certain methods may not be a satisfying solution.This might sound similar to #3512 and #6146.
But here the problem is, that using
*%W
explicitly improves readability.The text was updated successfully, but these errors were encountered: