-
Notifications
You must be signed in to change notification settings - Fork 74
Comparing changes
Open a pull request
base repository: ruby/net-http
base: v0.6.0
head repository: ruby/net-http
compare: master
- 14 commits
- 4 files changed
- 5 contributors
Commits on Dec 10, 2024
-
Don't double-interrupt the test HTTP server
The shutdown process here attempted to terminate the test server by interrupting it with Thread#kill, and then proceeded to close the server and join the thread. The kill does indeed interrupt the accept call, but the close call could also interrupt the thread as part of notifying blocked threads waiting on that socket call. In JRuby, where all of this can happen at the same time, it leads to the following scenario: * The server thread enters TCPServer#accept and blocks. * The main thread calls Thread#kill to interrupt the accept call. * The server thread wakes up and starts to propagate the kill. There is a slight delay between this wakeup and removing the server thread from the TCPServer's blocked threads list. * The main thread calls TCPServer#close, which sees that the server thread is still in the blocked list, so it initiates a second interrupt to raise IOError "closed in another thread" on the server thread. * As the kill is bubbling out, another check for interrupts occurs, causing it to see the new raise interrupt and propagate that instead of the active kill. * Because the server is now closed and the rescue here is empty, the server loop will endlessly attempt and fail to call accept. I was unable to determine how CRuby avoids this race. There may be code that prevents an active kill interrupt from triggering further interrupts. In order to get these tests running on JRuby, I've made the following changes: * Only kill the thread; one interrupt is sufficient to break it out of the accept call. * Ensure outside the server loop that the server gets closed. This happens within the server thread, so triggers no new interrupts. * Minor cleanup for the pattern of using @ssl_server or @server. This change avoids the race in JRuby (and possibly other parallel- threaded implementations) and does not impact the behavior of the tests.
Configuration menu - View commit details
-
Copy full SHA for 54025b3 - Browse repository at this point
Copy the full SHA 54025b3View commit details
Commits on Dec 16, 2024
-
Remove unnecessary alias links
Those alias methods have been marked as `:nodoc: obsolete` for a long time. Which means the `rdoc-ref` links to them will be broken. Unless we want to encourage users to use them again, we don't need to mention them in the documentation.
Configuration menu - View commit details
-
Copy full SHA for 5e34e74 - Browse repository at this point
Copy the full SHA 5e34e74View commit details -
Use proper
rdoc-ref
to link toOpenSSL::SSL::SSLContext
methodsSince `net-http` doesn't have its own documentation site and is always included in the Ruby documentation, we should use the proper `rdoc-ref` to link to `OpenSSL::SSL::SSLContext` methods, not linking to `docs.ruby-lang.org`.
Configuration menu - View commit details
-
Copy full SHA for 9bcf818 - Browse repository at this point
Copy the full SHA 9bcf818View commit details
Commits on Dec 23, 2024
-
Bump rubygems/release-gem from 1.1.0 to 1.1.1
Bumps [rubygems/release-gem](https://github.com/rubygems/release-gem) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/rubygems/release-gem/releases) - [Commits](rubygems/release-gem@9e85cb1...a25424b) --- updated-dependencies: - dependency-name: rubygems/release-gem dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 74862f8 - Browse repository at this point
Copy the full SHA 74862f8View commit details -
Merge pull request #200 from ruby/dependabot/github_actions/rubygems/…
…release-gem-1.1.1 Bump rubygems/release-gem from 1.1.0 to 1.1.1
Configuration menu - View commit details
-
Copy full SHA for 0b60ca6 - Browse repository at this point
Copy the full SHA 0b60ca6View commit details
Commits on Dec 31, 2024
-
Merge pull request #197 from headius/no_double_interrupt_test_server
Don't double-interrupt the test HTTP server
Configuration menu - View commit details
-
Copy full SHA for e18aa61 - Browse repository at this point
Copy the full SHA e18aa61View commit details -
Provide a 'Changelog' link on rubygems.org/gems/net-http
By providing a 'changelog_uri' in the metadata of the gemspec a 'Changelog' link will be shown on https://rubygems.org/gems/net-http which makes it quick and easy for someone to check on the changes introduced with a new version. Details of this functionality can be found on https://guides.rubygems.org/specification-reference/#metadata
Configuration menu - View commit details
-
Copy full SHA for eeb728f - Browse repository at this point
Copy the full SHA eeb728fView commit details
Commits on Jan 6, 2025
-
Merge pull request #201 from mark-young-atg/provide_changelog_link_on…
…_rubygems Provide a 'Changelog' link on rubygems.org/gems/net-http
Configuration menu - View commit details
-
Copy full SHA for 6991844 - Browse repository at this point
Copy the full SHA 6991844View commit details
Commits on Jan 13, 2025
-
Bump step-security/harden-runner from 2.10.2 to 2.10.3
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.2 to 2.10.3. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@0080882...c95a14d) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 838ed4c - Browse repository at this point
Copy the full SHA 838ed4cView commit details
Commits on Jan 14, 2025
-
Merge pull request #203 from ruby/dependabot/github_actions/step-secu…
…rity/harden-runner-2.10.3 Bump step-security/harden-runner from 2.10.2 to 2.10.3
Configuration menu - View commit details
-
Copy full SHA for ce722bf - Browse repository at this point
Copy the full SHA ce722bfView commit details
Commits on Jan 20, 2025
-
Bump step-security/harden-runner from 2.10.3 to 2.10.4
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.3 to 2.10.4. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@c95a14d...cb605e5) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3ef3dd - Browse repository at this point
Copy the full SHA f3ef3ddView commit details -
Merge pull request #204 from ruby/dependabot/github_actions/step-secu…
…rity/harden-runner-2.10.4 Bump step-security/harden-runner from 2.10.3 to 2.10.4
Configuration menu - View commit details
-
Copy full SHA for ae6c43c - Browse repository at this point
Copy the full SHA ae6c43cView commit details
Commits on Feb 17, 2025
-
Bump step-security/harden-runner from 2.10.4 to 2.11.0
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.4 to 2.11.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@cb605e5...4d991eb) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae1e8af - Browse repository at this point
Copy the full SHA ae1e8afView commit details
Commits on Feb 18, 2025
-
Merge pull request #208 from ruby/dependabot/github_actions/step-secu…
…rity/harden-runner-2.11.0 Bump step-security/harden-runner from 2.10.4 to 2.11.0
Configuration menu - View commit details
-
Copy full SHA for 1df8628 - Browse repository at this point
Copy the full SHA 1df8628View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.6.0...master