Duplicate comments?

[ioquatix]

Following the example:

> instance.methods[:gsub].comments.size
=> 4

Did I do something wrong? The 4 comments all seem identical?

[hdf1996]

I've been able to reproduce, the location in fact seems to be the same, even the position.

Seems like it not only happens with that method. I've also tried with slice but probably happens with others

11] pry(main)> instance.methods[:gsub].comments.map(&:location)
=> [#<RBS::Location:7720 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=1816:2, pos=57378...57861, children= source='# <!--'>,
 #<RBS::Location:7720 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=1816:2, pos=57378...57861, children= source='# <!--'>,
 #<RBS::Location:7720 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=1816:2, pos=57378...57861, children= source='# <!--'>,
 #<RBS::Location:7720 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=1816:2, pos=57378...57861, children= source='# <!--'>]

[10] pry(main)> instance.methods[:slice].comments.map(&:location)
=> [#<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>,
 #<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>,
 #<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>,
 #<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>,
 #<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>,
 #<RBS::Location:8480 buffer=/home/hfarji/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/rbs-2.6.0/core/string.rbs, start=888:2, pos=25452...28393, children= source='# <!--'>]

[hdf1996]

Just for reference, I've tried this with the code mentioned at https://github.com/ruby/rbs#library and at least I've been able to reproduce with rbs 2.6.0 in ruby 3.1.2

[soutaro]

Ok, deduping would make sense. Thanks!