Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for .codeowner files within [bracketed] directories #103

Closed
jksmithing opened this issue Jul 18, 2024 · 1 comment · Fixed by #106
Closed

Support for .codeowner files within [bracketed] directories #103

jksmithing opened this issue Jul 18, 2024 · 1 comment · Fixed by #106
Assignees
@schoblaska
Labels
enhancement New feature or request

Comments

@jksmithing
Copy link

jksmithing commented Jul 18, 2024 •
edited
Loading

// @team annotations now work within directories that contain bracket characters since #87 was resolved, but .codeowner files don't seem to work.

For context, brackets, parentheses, and other special characters are used in file paths by popular frontend frameworks like Next.js and Remix for defining route structures.
@github-actions github-actions bot added the triage A new issue that needs review by the core team label Jul 18, 2024
@schoblaska schoblaska added enhancement New feature or request and removed triage A new issue that needs review by the core team labels Jul 23, 2024
@schoblaska schoblaska self-assigned this Jul 26, 2024
@jksmithing
Copy link
Author

We can no longer repro this issue! Will re-open if we run into it again

@jksmithing jksmithing closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@schoblaska schoblaska reopened this Aug 12, 2024
@schoblaska schoblaska mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schoblaska schoblaska

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

escape globs derived from .codeowner files rubyatscale/code_ownership
2 participants
@schoblaska @jksmithing