You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The syntax for CODEOWNERS, as described by GitHub, permits multiple owners.
E.g.
/scripts/ @doctocat @octocat
code_ownership doesn't appear to support this (I've tried lots of permutations, none work. Documentation only ever references team in the singular). It'd be great if it were able to accept a comma separated string, one per line for the file type, or something like that 🤷. Allowing us to define multiple teams as owners of areas.
# .codeowner
Team One, Team Two
or
# @team Team One, Team Two
The text was updated successfully, but these errors were encountered:
It's particularly useful when trying to break apart a monolith. Team1 owns most of app/services/users/ while Team2 owns send_notification.rb, but Team2 hasn't moved the file elsewhere yet because either it still contains code Team1 owns or it doesn't have another home yet. Both teams are still interested in changes to that file.
If you want to pursue this functionality in a way that is opt-in, we're open to review it. We'd like to be able to continue to require one owner per file, but having an option to change that setting would be fine. Alex wrote:
"Typically I've dealt with that by finding ways to improve the boundaries/responsibility of the file. The tool as originally designed was meant to be opinionated such that mega-files with too much responsibility go against the grain a bit.
The benefit of this is the tool becomes a lot easier to maintain and use in a lot of ways, although might be interesting to support it as an isolated experiment to better understand how it affects the structure and usage of the tool!"
The syntax for CODEOWNERS, as described by GitHub, permits multiple owners.
E.g.
code_ownership
doesn't appear to support this (I've tried lots of permutations, none work. Documentation only ever references team in the singular). It'd be great if it were able to accept a comma separated string, one per line for the file type, or something like that 🤷. Allowing us to define multiple teams as owners of areas.or
The text was updated successfully, but these errors were encountered: