Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger-packwerk does not add an inline comment on deprecated_references.yml under some circumstances #2

Closed
alexevanczuk opened this issue Apr 18, 2022 · 0 comments · Fixed by #3

Comments

@alexevanczuk
Copy link
Contributor

danger-packwerk tries to drop in an inline comment on the constant in a deprecated_refrences.yml file.

That constant is often part of the visible diff if the user is adding a new violation. However, if they are adding a new reference to an existing violation and there are enough existing referencing files to push that constant out of the diff, danger-packwerk will not post the inline comment (since Github does not permit inline comments on lines that are not part of the visible diff). As a result, it does not comment silently.

Here are some other possible solutions:

  1. We could drop it as a comment on the top-level PR. I don’t love this solution though
  2. If there are existing references to the constant, I can drop the comment on the first new file that references the constant, rather than on the constant itself. This is probalby the simplest solution.
This was referenced Apr 18, 2022
@alexevanczuk alexevanczuk linked a pull request Apr 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant