fix: router destinationsMap access #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
changed the title
Codecov ReportBase: 43.97% // Head: 43.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2582 +/- ##
==========================================
- Coverage 43.97% 43.95% -0.02%
==========================================
Files 187 187
Lines 39082 39082
==========================================
- Hits 17185 17180 -5
- Misses 20817 20823 +6
+ Partials 1080 1079 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Sidddddarth we may need to fail events for which no configuration can be found instead of aborting them. A test scenario for this would be desirable too. |
Sidddddarth
force-pushed
the
fix.routerDestinationsMapAccess
branch
from
02090f6 to
fd0aeb3
Compare
cisse21
approved these changes
Oct 18, 2022
chandumlg
approved these changes
Oct 18, 2022
Closed
atzoum
reviewed
Oct 18, 2022
| worker.rt.configSubscriberLock.RUnlock() | ||
| if !ok { | ||
| status := jobsdb.JobStatusT{ | ||
| JobID: job.JobID, | ||
| AttemptNum: job.LastJobStatus.AttemptNum, | ||
| JobState: jobsdb.Aborted.State, | ||
| JobState: jobsdb.Failed.State, |
There was a problem hiding this comment.
@Sidddddarth we need to update the status of the job in the barrier, since failed jobs are notified early, at this stage
1 task
This was referenced Nov 7, 2022
Merged
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accessing
destinationwithout checking for its existence first. Fixes that.Notion Ticket
fix: router destination map access
Security