-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(warehouse): unrecognized schema in warehouse #2638
Conversation
Codecov ReportBase: 43.90% // Head: 43.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2638 +/- ##
==========================================
- Coverage 43.90% 43.83% -0.07%
==========================================
Files 187 187
Lines 40038 40088 +50
==========================================
- Hits 17579 17574 -5
- Misses 21363 21416 +53
- Partials 1096 1098 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…t.unrecognized-warehouse-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Simple change in naming. Nothing special. If you feel it looks good handle it otherwise it's okay.
Good Job 🥳 🎉
…t.unrecognized-warehouse-schema
…rlabs/rudder-server into feat.unrecognized-warehouse-schema
Description
The changes revolve around
uploadSchema
andschemaInWarehouse
terminology.uploadScheme
It is being prepared by consolidating local schema (copy of warehouse schema) and staging files schema.schemaInWarehouse
It is being prepared by querying the warehouse destinations and mapping them with datatypes supported by Rudderstack. During the fetching of the schema from the warehouse destinations, if there are some datatypes that are not supported by RudderStack we skip those.During the loading of the data, we calculate schema diff between the
uploadScheme
andschemaInWarehouse
to create the necessary tables and columns. There are two things:schemaInWarehouse
is skipping the unsupported datatypes, it is resulting in creating columns every time for unsupported datatypes. Errors are being suppressed.ALTER
queries, we stopped suppressing the errors because one or more columns already present will result in other columns not getting altered.So, we introduced one more parameter called
unrecognizedSchema
which will be populated during the fetching of the schema from unsupported datatypes. We are using it to ignore columns that are already present in the warehouse.Notion Ticket
https://www.notion.so/rudderstacks/Warehouse-unrecognized-schema-4029829a49564d5087a2186464b63e63
Security