chore(warehouse): handle schema change #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
requested review from
abhimanyubabbar,
Jayachand and
lvrach
and removed request for
abhimanyubabbar
achettyiitr
force-pushed
the
chore.schema-table_driven-test
branch
from
67b8507 to
c196dbc
Compare
lvrach
reviewed
Nov 4, 2022
lvrach
reviewed
Nov 4, 2022
lvrach
reviewed
Nov 4, 2022
achettyiitr
force-pushed
the
chore.schema-table_driven-test
branch
from
c196dbc to
40ddf07
Compare
Codecov ReportBase: 45.47% // Head: 45.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2654 +/- ##
==========================================
+ Coverage 45.47% 45.62% +0.14%
==========================================
Files 289 289
Lines 48001 48007 +6
==========================================
+ Hits 21830 21904 +74
+ Misses 24784 24716 -68
Partials 1387 1387
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lvrach
reviewed
Nov 4, 2022
lvrach
reviewed
Nov 4, 2022
achettyiitr
force-pushed
the
chore.schema-table_driven-test
branch
from
1b4dc9e to
37e1149
Compare
achettyiitr
force-pushed
the
chore.schema-table_driven-test
branch
from
37e1149 to
e06c501
Compare
…re.schema-table_driven-test
lvrach
reviewed
Nov 10, 2022
warehouse/schema.go
Outdated
Comment on lines
27
to
34
| const ( | ||
| StringDataType = "string" | ||
| BooleanDataType = "boolean" | ||
| IntDataType = "int" | ||
| BigIntDataType = "bigint" | ||
| FloatDataType = "float" | ||
| JSONDataType = "json" | ||
| TextDataType = "text" |
There was a problem hiding this comment.
Suggested change
| const ( | |
| StringDataType = "string" | |
| BooleanDataType = "boolean" | |
| IntDataType = "int" | |
| BigIntDataType = "bigint" | |
| FloatDataType = "float" | |
| JSONDataType = "json" | |
| TextDataType = "text" | |
| const ( | |
| StringSchemaType SchemaType = "string" | |
| BooleanSchemaType = "boolean" | |
| IntSchemaType = "int" | |
| BigIntSchemaType = "bigint" | |
| FloatSchemaType = "float" | |
| JSONSchemaType = "json" | |
| TextSchemaType = "text" |
There was a problem hiding this comment.
Added these. Also, moved this to the models package.
…re.schema-table_driven-test
achettyiitr
changed the title
achettyiitr
commented
Nov 11, 2022
|
|
||
| const ( | ||
| StringDataType SchemaType = "string" | ||
| BooleanDataType SchemaType = "boolean" |
There was a problem hiding this comment.
only the first constant in this group has an explicit type
https://stackoverflow.com/questions/55282615/golangci-lint-constant-explicit-type
…re.schema-table_driven-test
lvrach
approved these changes
Nov 15, 2022
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Schema Test
Use table-driven tests to handle schema change. The benefit here is we can be able to run these tests parallelly.
Handle Schema Change Behaviour
This is applied to the mismatch of data types between the warehouse schema and staging files schema.
Existing behavior
Current behavior
ErrIncompatibleSchemaConv, when we are trying to do the conversion of the data but we are not able to do it.ErrSchemaConvNotSupported, when we don't support the conversion of the data.Notion Ticket
https://www.notion.so/rudderstacks/Handle-schema-table-driven-tests-751462cd730d4e4aaf92fba22c575c34
Security