Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preferences should be false incase of invalid bucket #2661

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix: preferences should be false incase of invalid bucket #2661

merged 1 commit into from
Nov 7, 2022

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Nov 7, 2022 •
edited
Loading

Description

Setting all backup preferences to false incase there is invalid bucket provided

Notion Ticket

https://www.notion.so/rudderstacks/Allow-Customers-to-use-self-storage-26f45f75e38b4ef6bd872bea6187aa06

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@BonapartePC BonapartePC marked this pull request as ready for review November 7, 2022 16:42
fracasula
fracasula requested changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test where an invalid bucket configuration is provided and then you call GetStoragePreferences with the right assertions?

@BonapartePC
Copy link
Contributor Author

Can you please add a test where an invalid bucket configuration is provided and then you call GetStoragePreferences with the right assertions?

Added a test

@BonapartePC BonapartePC merged commit 725e9e7 into master Nov 7, 2022
@rudder-server-bot rudder-server-bot mentioned this pull request Nov 7, 2022
Closed
@chandumlg chandumlg deleted the fix.fileuploader branch November 7, 2022 18:29
This was referenced Nov 7, 2022
Merged
Merged
Merged
Merged
Closed
Closed
This was referenced Dec 1, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atzoum atzoum atzoum approved these changes

@chandumlg chandumlg chandumlg approved these changes

@cisse21 cisse21 cisse21 approved these changes

@fracasula fracasula fracasula approved these changes

Assignees
No one assigned
Labels
server-team with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BonapartePC @fracasula @atzoum @cisse21 @chandumlg