feat(warehouse): added support for bigquery custom partition for workspaceIDs #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.45% // Head: 45.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
==========================================
- Coverage 45.45% 45.44% -0.02%
==========================================
Files 289 289
Lines 47949 47997 +48
==========================================
+ Hits 21794 21811 +17
- Misses 24768 24796 +28
- Partials 1387 1390 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
achettyiitr
force-pushed
the
chore.bq-custom-partition-workspaceids
branch
from
83e4b9a to
359bdc3
Compare
achettyiitr
requested review from
lvrach,
Jayachand,
abhimanyubabbar and
a team
Jayachand
approved these changes
Nov 10, 2022
…re.bq-custom-partition-workspaceids
lvrach
reviewed
Nov 10, 2022
Jayachand
approved these changes
Nov 10, 2022
lvrach
approved these changes
Nov 10, 2022
lvrach
reviewed
Nov 10, 2022
config/load.go
Outdated
| if !isSet { | ||
| _value = configVal.defaultValue.([]string) | ||
| } | ||
| if !reflect.DeepEqual(_value, *value) { |
There was a problem hiding this comment.
Should we do a normal []string comparison instead of reflect?
There was a problem hiding this comment.
Using slices.Compare(_value, *value) != 0 now.
achettyiitr
changed the title
achettyiitr
changed the title
Closed
Closed
This was referenced Dec 1, 2022
Merged
atzoum
added a commit
that referenced
this pull request
Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679) chore: by default enable max concurrent gw request limit. (#2648) doc: create SECURITY.md (#2656) chore: use bugsnag in router and processor goroutines (#2686) test: using arm64 compatible images if necessary (#2670) chore: regulation worker avoid panic in case of timeout (#2657) feat(warehouse): degraded workspace id (#2627) Release-As: 1.4.0
atzoum
added a commit
that referenced
this pull request
Dec 1, 2022
feat(warehouse): added support for bigquery custom partition for workspaceIDs (#2679) chore: by default enable max concurrent gw request limit. (#2648) doc: create SECURITY.md (#2656) chore: use bugsnag in router and processor goroutines (#2686) test: using arm64 compatible images if necessary (#2670) chore: regulation worker avoid panic in case of timeout (#2657) feat(warehouse): degraded workspace id (#2627) Release-As: 1.4.0
This was referenced Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
customPartitionsEnabledwhich is at a workspace level.customPartitionsEnabledWorkspaceIDswhich will take a list of workspace IDs that needs to have Custom Partition enabled.checkAndHotReloadConfig.Partitioned tracks table looks like this
Error experienced without changes
Notion Ticket
https://www.notion.so/rudderstacks/BQ-custom-partition-fix-for-Multi-tenant-9c3262e69c8c4d4f8ecf6f91207e3352
Security