chore: compact status tables before proceeding with migration #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
changed the title
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
2 times, most recently
from
95cdfcd to
a48c1ab
Compare
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
a48c1ab to
8ca7b37
Compare
Codecov ReportBase: 46.63% // Head: 46.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2688 +/- ##
==========================================
+ Coverage 46.63% 46.84% +0.20%
==========================================
Files 297 298 +1
Lines 48696 48749 +53
==========================================
+ Hits 22711 22836 +125
+ Misses 24557 24482 -75
- Partials 1428 1431 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
8ca7b37 to
446523b
Compare
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
6 times, most recently
from
43822d6 to
a9c24c3
Compare
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
2 times, most recently
from
0d89d50 to
2647a06
Compare
atzoum
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
8892629 to
51a6134
Compare
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
51a6134 to
ce3066c
Compare
atzoum
changed the title
atzoum
approved these changes
Nov 24, 2022
atzoum
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
ce3066c to
ed67cd2
Compare
chandumlg
reviewed
Nov 24, 2022
atzoum
reviewed
Nov 24, 2022
Sidddddarth
force-pushed
the
chore.statusCleanUpDuringMigrationLoop
branch
from
e4e0623 to
2160cf7
Compare
chandumlg
requested changes
Nov 25, 2022
chandumlg
approved these changes
Nov 25, 2022
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up the status table(delete all but the latest status per job) before proceeding with migration.
The DSs this is done to, are selected via analyzer estimates(
pg_class.reltuples) and based on existing thresholds.This is once again repeated before the tables are backup, just to ensure that there's only one status per job in the uploaded file.
Moved migration related logic to
jobsdb/migration.go.Notion Ticket
Perform compaction on the rightmost dataset during migration if necessary
Security