Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workspaceid label to router aborted events #2724

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

chandumlg
Copy link
Member

Description

Add workspaceid label to router aborted events metric.

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=ee0f6d49ea664964ba3d610929f154af&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 45.71% // Head: 45.86% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (8391910) compared to base (4f0d189).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
+ Coverage   45.71%   45.86%   +0.15%     
==========================================
  Files         295      295              
  Lines       48499    48501       +2     
==========================================
+ Hits        22170    22247      +77     
+ Misses      24931    24855      -76     
- Partials     1398     1399       +1     
Impacted Files Coverage Δ
router/router.go 73.83% <100.00%> (+0.03%) ⬆️
jobsdb/jobsdb.go 73.26% <0.00%> (+0.18%) ⬆️
jobsdb/backup.go 76.65% <0.00%> (+0.34%) ⬆️
warehouse/schema.go 51.42% <0.00%> (+1.14%) ⬆️
services/db/recovery.go 53.01% <0.00%> (+2.40%) ⬆️
jobsdb/unionQueryLegacy.go 75.40% <0.00%> (+4.91%) ⬆️
processor/stash/stash.go 66.66% <0.00%> (+22.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 merged commit 8a04871 into master Nov 24, 2022
@cisse21 cisse21 deleted the chore.workspaceid-label-for-router-aborted-events branch November 24, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants