Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for request payloads using gzip content-encoding #2741

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 28, 2022

Description

Adding support for accepting requests using a gzipped body along with the appropriate Content-Encoding: gzip header.
Compressed request bodies are being uncompressed lazily and in a streaming fashion.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 46.85% // Head: 46.89% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (d0e8c6b) compared to base (9f006e5).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
+ Coverage   46.85%   46.89%   +0.04%     
==========================================
  Files         298      300       +2     
  Lines       48943    49099     +156     
==========================================
+ Hits        22931    23026      +95     
- Misses      24555    24609      +54     
- Partials     1457     1464       +7     
Impacted Files Coverage Δ
regulation-worker/internal/delete/api/api.go 67.53% <57.14%> (-13.39%) ⬇️
services/oauth/oauth.go 53.88% <76.92%> (-9.11%) ⬇️
middleware/uncompress.go 85.00% <85.00%> (ø)
gateway/gateway.go 63.32% <100.00%> (+0.03%) ⬆️
regulation-worker/cmd/main.go 68.25% <100.00%> (+0.51%) ⬆️
jobsdb/unionQueryLegacy.go 70.49% <0.00%> (-4.92%) ⬇️
services/db/recovery.go 54.76% <0.00%> (-1.20%) ⬇️
warehouse/bigquery/bigquery.go 1.11% <0.00%> (-0.01%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum force-pushed the feat.gzippedPayload branch from 8e49c41 to cd6acb2 Compare November 28, 2022 14:27
@atzoum atzoum changed the title [WIP] feat: add support for request payloads with content-encoding gzip feat: add support for request payloads using gzip content-encoding Nov 28, 2022
middleware/uncompress.go Outdated Show resolved Hide resolved
@atzoum atzoum requested a review from chandumlg November 29, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants