-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jobsdb): add support for schema migration changesets to run always #2746
Conversation
66caa37
to
f5fc1e9
Compare
Codecov ReportBase: 46.73% // Head: 46.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2746 +/- ##
==========================================
+ Coverage 46.73% 46.90% +0.17%
==========================================
Files 300 300
Lines 49123 49139 +16
==========================================
+ Hits 22958 23051 +93
+ Misses 24704 24619 -85
- Partials 1461 1469 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aa62bdc
to
3562cd5
Compare
3562cd5
to
ac1ad1b
Compare
Description
When running separate
gw
andprocessor
instances we cannot control the order that they get upgraded or how schema migrations get executed. Additionally, we cannot guarantee that while agw
schema migration is running or after it completes, aprocessor
running an older release will not create new tables using a previous schema.Changesets that run always can help in such scenarios, by bringing non-migrated tables into a usable state during a version upgrade or after starting up following a panic caused by an incompatible jobsdb table schema encounter.
Additional items
down
sql migration changesets since we are never performing a down migration, so these scripts are not used and have never been tested.Notion Ticket
Link
Security