Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a presentation to the demo #1629

Closed
ousia opened this issue Nov 21, 2020 · 6 comments
Closed

add a presentation to the demo #1629

ousia opened this issue Nov 21, 2020 · 6 comments

Comments

@ousia
Copy link
Contributor

ousia commented Nov 21, 2020

@Herschel.

I would love to add this talk (direct link: https://github.com/lhl/free_culture/raw/master/free_culture.swf [content licensed under CC BY-SA]) to the demo.

    {
      "location": "swfs/free_culture.swf",
      "title": "Free Culture",
      "author": "Lawrence Lessig",
      "authorLink": "https://www.lessig.org/",
      "type": "Presentation"
    }

But I’m afraid I don’t know where to add, since ruffle-rs/demo seems to be an automatically generated repository.

This talk from the Open Source Conference 2002 in San Diego. I can only recommend watching it (about 30min long).

BTW, as far as I can tell (from a fast check with the demo site), this presentation has feature parity in both Ruffle and Flash.

Congratulations for the nice work.

@Herschel
Copy link
Member

Herschel commented Nov 21, 2020

Thanks for the kind words! You should be able to make a PR to the demo repo, adding the SWF and change to swf.json, and it should be good; the nightly build should leave these files intact -- it does an amend commit that specifically avoids touching non-Ruffle related files.

@parkerlreed
Copy link

Funnily enough there's a bug with the movie. If you click pause and unpause it restarts the entire audio. Flash Player proper pauses correctly.

@ousia
Copy link
Contributor Author

ousia commented Nov 22, 2020

@parkerlreed, thanks for noticing this. I’d totally forgotten it.

This is caused because Sound.position() isn’t implemented yet (as I reported in #340).

I hope that, once PR #1445 is merged, Sound.position() could be implemented and the presentation would be ready to be added.

@ousia
Copy link
Contributor Author

ousia commented Nov 28, 2020

I posted an experimental version at https://www.free-culture.tk/fc.html.

@ousia
Copy link
Contributor Author

ousia commented Oct 19, 2021

Sound.position() has been already implemented, but I don’t know how to successfully add a commit for this presentation.

@ousia
Copy link
Contributor Author

ousia commented Aug 5, 2022

Closing this issue myself.

@ousia ousia closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants