Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastica\Filter\Bool does not work with other Bool filters as children #594

Closed
sten opened this issue Apr 21, 2014 · 3 comments
Closed

Elastica\Filter\Bool does not work with other Bool filters as children #594

sten opened this issue Apr 21, 2014 · 3 comments

Comments

@sten
Copy link

sten commented Apr 21, 2014

Given a Elastica\Filter\Bool object, if you add other \Elastica\Filter\Bool objects as should or must children, the query is not correctly generated. The toArray method is not called on these Filter\Bool children.

@sten
Copy link
Author

sten commented Apr 21, 2014

@ruflin I fixed the bug and I tried to push my local branch to create a pull request, but I get the following error:

remote: Permission to ruflin/Elastica.git denied to sten. 

How can I resolve this? Thanks!

@ruflin
Copy link
Owner

ruflin commented Apr 22, 2014

The problem is that you push to the ruflin/Elastica instead of your own fork. You must push to your own fork and open an pull request from there.

@sten
Copy link
Author

sten commented Apr 22, 2014

I am sorry for the trouble! I forked it and made a pull request in my fork. Thanks for the help!
#596

@ruflin ruflin closed this as completed in c66176d Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants